-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Deprecate ScanDate (PET) in favor of AcquisitionTime in scans.tsv files #798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would be interested in what others think.
In summary, it mentions the "official" way to write units for dates with the extra that time is optional in this case. I did not remember we had kept that piece of metadata for PET and thought we had fallen back on using scans.tsv to keep track of that. Doesn't that open the door for this piece of metadata to be stored in 2 different places and also have potentially conflicted info if that piece of information is stored in both places? (Sorry to have missed that one before the final merge and sorry to not remember how this discussion was resolved... Feel free to ignore). |
Yeah - that's the alternative. I guess it would be most clean to have everything in the scans.tsv/json file. |
+1 for deprecating ScanDate and recommending using acq_time in scans.tsv. |
Putting in scans.tsv is a better alternative -- it allows tool builders to consistently look for the time irrespective of modality |
Thank you all - I believe we seem to have a consensus. I will go ahead and make the necessary changes to the specification and the validator, and then make a PR. |
We need to keep the field around for backwards compatibility and mark it deprecated. I made a proposal in edf0237. |
Thanks @mnoergaard for starting this and everybody else for reviewing. |
This PR updates the description of the
ScanDate
field in the PET specification to be in accordance with the correct units for dates. The updates have been discussed here: https://github.com/bids-standard/bids-validator/pull/1283#issuecomment-844892636and the corresponding PR for the validator can be found here: https://github.com/bids-standard/bids-validator/pull/1290